Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trash can #297

Merged
merged 5 commits into from
Jul 12, 2017
Merged

Add trash can #297

merged 5 commits into from
Jul 12, 2017

Conversation

asmsuechan
Copy link
Contributor

@asmsuechan asmsuechan commented Feb 18, 2017 •
edited
Loading

I added trash can as well as the star.

screen shot 2017-02-18 at 23 35 03

TODO:

  • change the behavior of delete a note
  • fix that a trashed note is still shown on delete button clicked
  • add migrater like browser/main/lib/dataApi/migrateFromV6Storage.js

@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label May 17, 2017
@asmsuechan
Copy link
Contributor Author

asmsuechan commented Jun 12, 2017 •
edited
Loading

Must improve: Undo UI
screen shot 2017-06-13 at 01 06 29

@asmsuechan asmsuechan changed the title [WIP] Add trash can Add trash can Jun 13, 2017
asmsuechan
asmsuechan commented Jun 28, 2017
View reviewed changes
browser/main/Detail/MarkdownNoteDetail.js Outdated
</button>

// TODO: must refactor
const menuBar = location.pathname === '/trashed'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, this code is dirty. So I assume I have to make some new components for it.

@asmsuechan asmsuechan removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Jul 3, 2017
@asmsuechan
Copy link
Contributor Author

Escape from deletion when a user is in the trashed.
screen shot 2017-07-07 at 19 29 01

@asmsuechan asmsuechan merged commit dccb92d into BoostIO:master Jul 12, 2017
@asmsuechan asmsuechan deleted the add-trash-can branch July 12, 2017 06:53
@asmsuechan
Copy link
Contributor Author

ref: #263

@kohei-takata kohei-takata mentioned this pull request Jul 29, 2017
Merged
@kazup01 kazup01 mentioned this pull request Jul 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asmsuechan @kohei-takata @kazup01 @BoostnoteBot