Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix routing for tag filtering (issue #3157) #3191

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Fix routing for tag filtering (issue #3157) #3191

merged 1 commit into from
Aug 24, 2019

Conversation

AWolf81
Copy link
Contributor

@AWolf81 AWolf81 commented Jul 31, 2019

Description

Changed routing to use connected-react-router by dispatching push to Redux store.

Issue fixed

#3157

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 1, 2019
ZeroX-DG
ZeroX-DG approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 14, 2019
@Flexo013 Flexo013 requested a review from Rokt33r August 14, 2019 14:04
@Rokt33r Rokt33r removed the needs extra review 🔎 Pull request requires review from an additional reviewer. label Aug 24, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 24, 2019
@Rokt33r Rokt33r merged commit 7d04046 into BoostIO:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AWolf81 @ZeroX-DG @Flexo013 @Rokt33r