Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2636 #3206

Merged
merged 2 commits into from Aug 11, 2019
Merged

Fix 2636 #3206

merged 2 commits into from Aug 11, 2019

Conversation

hsiehjack
Copy link
Contributor

@hsiehjack hsiehjack commented Aug 7, 2019 •
edited by Flexo013

Description

Fix issue where the bottom of editor pane is not reachable by scroll.

Issue fixed

Fix #2636 and some of the linting issues.

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
IssueHunt Summary

Referenced issues

This pull request has been submitted to:

IssueHunt has been backed by the following sponsors. Become a sponsor

@hsiehjack hsiehjack changed the title Issue 2636 Fix 2636 Aug 7, 2019
@Flexo013 Flexo013 requested a review from ZeroX-DG August 7, 2019 11:57
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 7, 2019
@Flexo013 Flexo013 removed the request for review from ZeroX-DG August 7, 2019 11:57
ZeroX-DG
ZeroX-DG approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 11, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r August 11, 2019 11:00
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 11, 2019
@Rokt33r Rokt33r merged commit f09297f into BoostIO:master Aug 11, 2019
@Flexo013
Copy link
Contributor

This might be the cause of #3289 and #3273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
needs extra review 🔎 Pull request requires review from an additional reviewer.
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Can't scroll to bottom of editor pane
4 participants
@hsiehjack @Flexo013 @ZeroX-DG @Rokt33r