-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zh-TW.json #3537
Update zh-TW.json #3537
Conversation
@opw0011 @PeterDaveHello would you like to help review my changes? |
"⚠ You have pasted a link referring an attachment that could not be found in the storage location of this note. Pasting links referring attachments is only supported if the source and destination location is the same storage. Please Drag&Drop the attachment instead! ⚠": "⚠ 您貼上了一個不存在本筆記儲存空間的附加檔案連結。貼上附加檔案連結功能只支援剪下貼上於相同儲存空間之間。請改以拖拉 Drag&Drop 附加檔案!⚠", | ||
"Spellcheck disabled": "拼寫檢查已關閉", | ||
"Save tags of a note in alphabetical order": "依照字母排序儲存標籤", | ||
"Enable live count of notes": "啟用即時統計筆記數量", | ||
"Enable smart table editor": "啟用智能表格編輯器", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the changes of context, I believe that this one should also be revised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the term of smart should be revised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinions here, from the code it appears to enable the editor activity handler. I'm not exactly sure how "smart" it is, but would like to stay with the original if we don't have other better alternatives.
https://github.com/BoostIO/Boostnote/blob/0d797ce8a86c2701bda332c97af34e7fd0d1bb07/browser/main/modals/PreferencesModal/UiTab.js#L817
https://github.com/BoostIO/Boostnote/blob/592aca1539166bb9a6d1eaf36a20203fff584c37/browser/components/CodeEditor.js#L491
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "智能" should be "智慧"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, you were a bit too late, this commit has been merged. You may submit another PR for such change.
I've fixed most of the suggestions above. |
Maybe also squash the commits after final fixes? |
- Update zh-TW translation. - Sync with [locales/en.json](https://github.com/BoostIO/Boostnote/blob/e44381f295a8c6c7d2391bb7edab5cc9730c72a0/locales/en.json).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem ok, I'll approve it
Description
Issue fixed
Type of changes
Checklist: