Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new line problem in list and task list #425

Merged
merged 1 commit into from
Apr 22, 2017

Conversation

aweekj
Copy link
Contributor

@aweekj aweekj commented Apr 14, 2017

Hello. I changed the code to use newlineAndIndentContinueMarkdownList which is defined in node_module/codemirror/addon/edit/continuelist.jsof library namedcodemirror. It'll fix the new line issues in list and task list.

This will cover these issues in List of the requested features

  • Remove last list item when Enter pressed on empty list item. #42
  • Task list should append - [ ] instead of - when Enter pressed.

Before

before

After

after

@kazup01
Copy link
Member

kazup01 commented Apr 14, 2017

Wow, great!! Thank you for your cooperation @aweekj san 🎉 We'll check it!

@ilyeshammadi
Copy link

Great work 👍 🥇

Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us.
Thanks a log :)

@sota1235 sota1235 merged commit eea8f7c into BoostIO:master Apr 22, 2017
@sota1235 sota1235 mentioned this pull request Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants