Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a shortcut for deletion #484

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Fix a shortcut for deletion #484

merged 1 commit into from
Apr 24, 2017

Conversation

asmsuechan
Copy link
Contributor

Sadly, I forgot to rename this function name in #340 馃槰 Due to this, a bug happens and we cannot use a shortcut for deletion a note. Sorry for inconvenient.

The error message

Uncaught TypeError: o.refs.root.handleDeleteMenuClick is not a function

ENV

  • macOS
  • Boostnote v0.8.8

screen shot 2017-04-22 at 15 28 43

Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(We should consider about this bug.)

@sota1235 sota1235 merged commit 75b2c7b into BoostIO:master Apr 24, 2017
@sota1235 sota1235 mentioned this pull request Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants