Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #535: #549

Merged
merged 1 commit into from
Jun 3, 2017
Merged

Fix for #535: #549

merged 1 commit into from
Jun 3, 2017

Conversation

LetItRock
Copy link
Contributor

@LetItRock LetItRock commented May 4, 2017 •
edited

Fix for #535:

  • hide/show code editor based on markdown editor state (could be CODE or PREVIEW);
  • changed styles for code editor;

I did changes the same way as there were for markdown preview component.

@LetItRock
Fix for #535:
90846fa 
- hide/show code editor based on markdown editor state (could be CODE or PREVIEW);
- changed styles for code editor;
@kazup01
Copy link
Member

kazup01 commented May 10, 2017

Thanks @LetItRock !

@kazup01 kazup01 added the UI label May 17, 2017
@kazup01 kazup01 requested a review from sosukesuzuki June 3, 2017 02:27
sosukesuzuki
sosukesuzuki approved these changes Jun 3, 2017
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for send PR, @LetItRock . I think your code has no matter and so good! We will merge this PR.

@kazup01
Copy link
Member

kazup01 commented Jun 3, 2017

Thanks for @LetItRock ! We will release it at next version.

@kazup01 kazup01 merged commit c8259ab into BoostIO:master Jun 3, 2017
@kazup01 kazup01 added Next Release and removed UI labels Jun 3, 2017
@kohei-takata kohei-takata mentioned this pull request Jun 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LetItRock @kazup01 @sosukesuzuki @kohei-takata