Edit initial files #681
Merged
Edit initial files #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kazup01
commented
Jul 5, 2017
kazup01
commented
asmsuechan
reviewed
Jul 6, 2017
browser/main/modals/InitModal.js
Outdated
| type: 'MARKDOWN_NOTE', | ||
| folder: data.storage.folders[0].key, | ||
| title: 'Welcome to Boostnote!', | ||
| content: '# Welcome to Boostnote! \n### _Click to edit this note._\n\n---\n\nBoostnote is an *open source* note-taking app. \nRepository is published on [GitHub](https://github.com/BoostIO/Boostnote), and tweeting everyday on [@Boostnoteapp](https://twitter.com/boostnoteapp)!\n\n## Features \n- [x] No Internet and Registration Required. \n- [ ] Quick search and copy the content of note. `macOS: Cmd + Alt + S / windows: Super + Alt + S` \n- [ ] Markdown & Snippet note. \n- [ ] Available for `vim` and `emacs` mode. \n- [ ] Choose your favorite theme on UI, Editor and Code Block! \n--- \n\n- Copy Codeblock on Makrdown Preview.\n```javascript\nvar boostnote = document.getElementById(\'enjoy\').innerHTML\n\nconsole.log(boostnote)\n```' |
There was a problem hiding this comment.
windows: Super + Alt + S
Ctrl?
asmsuechan
reviewed
Jul 7, 2017
| @@ -160,6 +147,19 @@ class InitModal extends React.Component { | |||
| note: note | |||
| }) | |||
| }) | |||
| let defaultMarkdownNote = dataApi | |||
There was a problem hiding this comment.
Are there any reasons what you moved the variable?
There was a problem hiding this comment.
Because it changes order of the first two contents (markdown and snippet).
Before
After
|
Works fine. |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.