Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image path relative #730

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Make image path relative #730

merged 2 commits into from
Jul 26, 2017

Conversation

asmsuechan
Copy link
Contributor

context

I made the path of a dropped image relative.

before

The path of a dropped images was an absolute path such as /Users/asmsuechan/Boostnote/images/aaaaaaaaaaaa.png.

after

/:storage/aaaaaaaaaaaaaa.png works now.

00be270d78ed9b3632159f76e8f8fcc2

@asmsuechan
Copy link
Contributor Author

asmsuechan commented Jul 26, 2017

I made finder work fine.

before

image

after

image

@asmsuechan asmsuechan merged commit e864645 into BoostIO:master Jul 26, 2017
@asmsuechan asmsuechan deleted the make-image-path-relative branch July 26, 2017 05:33
@kohei-takata kohei-takata mentioned this pull request Jul 29, 2017
@Ryomasao
Copy link

I tried drag & drop image.
But it is not working.
I use latest version(Boostnote 0.8.14)

ezgif-2-7ef0c7bd12

@Germanc
Copy link

Germanc commented Sep 17, 2017

I have the same issue on Linux, version 0.8.14. Drag & drop copies the image to /Storage/images but nothing is added to the note

@asmsuechan
Copy link
Contributor Author

asmsuechan commented Sep 17, 2017

It's already fixed. It will be released soon.
#820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants