Pin to top #956
Merged
Pin to top #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing the picture above, I think the pin icon should be brighter, and I think a white pin to use in dark themes is neccessary too. Thanks. |
|
I'm not in charge of style. That's why I ignore the ugly icon in spite of knowing that the style is not good. However, thank you for your comment. |
|
Great contribution @asmsuechan 🎉 |
Merged
|
This feature has just released at v0.8.16! Thanks @asmsuechan 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
Pin to topfeature is implemented.before
This is a new feature so there's no
before.after
I'll write this later.
for tests