Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working PlantUML on Non-English #2081

Closed
garmede opened this issue Jun 14, 2018 · 6 comments
Closed

Not working PlantUML on Non-English #2081

garmede opened this issue Jun 14, 2018 · 6 comments
Labels
bug 🐛 Issue concerns a bug.

Comments

@garmede
Copy link

garmede commented Jun 14, 2018

Current behavior

boostnote_2018-06-14_16-59-56

Expected behavior

Steps to reproduce

  1. Use Non-English between @startuml and @enduml

Environment

  • Version :11.6
  • OS Version and name :Windows7
@sosukesuzuki sosukesuzuki added the bug 🐛 Issue concerns a bug. label Jun 14, 2018
@arnaudroques
Copy link

It looks like the Non-English text has not been encoded in UTF8.
(see http://plantuml.com/text-encoding )

@yosmoc
Copy link
Member

yosmoc commented Jun 20, 2018

Yes, markdown-it-plantuml that is used in boostnote doesn't encode before sending to server. This pull request solved this problem and it is in the review status. I hope it will be included in the next release. Next release will come in this week.

I will make PR for updating mardown-it-plantuml after this update.

@IssueHuntBot
Copy link

@BoostIO funded this issue with $30. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@yosmoc has started working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@yosmoc has submitted output. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@kazup01 has rewarded. Visit this issue on Issuehunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

No branches or pull requests

5 participants