Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck #2176

Closed
ehhc opened this issue Jul 3, 2018 · 6 comments
Closed

Spellcheck #2176

ehhc opened this issue Jul 3, 2018 · 6 comments
Labels
feature request 🌟 Issue is a new feature request.

Comments

@ehhc
Copy link
Contributor

ehhc commented Jul 3, 2018

It has been mentioned several times that it would be nice to have a spell check feature.
I implemented one for markdown notes but it is some kind of slow and the performance is not that good. Maybe you can have a look at it and decide if we want to include it in boostnote (ignoring the performance issues) or if you can help to improve it..

Eventhough it's not perfect, it has been a lot of work so i would love to hear your suggestions.. @Rokt33r ?

@Rokt33r
Copy link
Member

Rokt33r commented Jul 3, 2018

I think we should exploit native spell checker which OS providing.

I assume we could give a shot to this.
https://github.com/atom/node-spellchecker

@ehhc
Copy link
Contributor Author

ehhc commented Jul 3, 2018

I thought about that as well but I found one problem (maybe you've a solution for it though..): you are stuck with the language your OS is using and cannot change it.
Consider the following use case:
The language of my OS is German. But I have some notes written in German, and some in English. Using a spell check relying on the OS I could only check German notes but cannot change to English (since I don't want to change my whole OS to English just to check that one note)..

That's why I used an independent spell check.
Do you have ideas how to solve this problem?

@Rokt33r
Copy link
Member

Rokt33r commented Jul 3, 2018

https://github.com/atom/node-spellchecker/blob/master/lib/spellchecker.js#L28
We could do it with node-spellchecker. Seems we could change it locale via environment variables.

So we could deal with the problem by spawning a child process with other LANG value.

@ehhc
Copy link
Contributor Author

ehhc commented Jul 4, 2018

First, i don't know what child process you might want to spawn.. i have absolutely no idea.
Second Windows dosen't care for the LANG evnironmental variable because it dosen't know about it. (atom/node-spellchecker#72 (comment))
So for windows there is no solution to switch languages..

I think using a hunspell-based checker (like the one i used) is better in that case because we do have control over the language in that case!

@Rokt33r did you tryied my PR? It works, it is slow but at least it works..

@Rokt33r Rokt33r added the feature request 🌟 Issue is a new feature request. label Jul 5, 2018
@IssueHuntBot
Copy link

@kazup01 funded this issue with $10. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@kazup01 cancelled funding, $10, of this issue. Visit this issue on Issuehunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants