Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize All Keyboard Shortcuts #2645

Open
colineberly opened this issue Nov 25, 2018 · 12 comments
Open

Customize All Keyboard Shortcuts #2645

colineberly opened this issue Nov 25, 2018 · 12 comments
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!

Comments

@colineberly
Copy link

Current behavior

Currently, it looks like you can only customize three of the Hotkeys/Keyboard Shortcuts. Are there any plans in the future to add the ability to customize all hotkeys? I find focusing the search box with Cmd + Shift + L to be rather annoying. Please tell me I am missing a setting somewhere where I can customize them all.

screenshot

Expected behavior

Customize all Hotkeys/Shortcuts

Steps to reproduce

N/A

Environment

  • Version : 0.11.11
  • OS Version and name : macOS High Sierra (10.13.6)
@ZeroX-DG ZeroX-DG added the feature request 🌟 Issue is a new feature request. label Nov 26, 2018
@ZeroX-DG
Copy link
Member

Our shortcut system is pretty messy, currently, you can't customize other hotkeys because they're hardcoded.

@colineberly
Copy link
Author

Thanks for taking the time to reply. Is this a possibility in the future?

@ZeroX-DG
Copy link
Member

Not in the near future, I think. It's pretty messy in the code right now and the project maintainers are very busy and working on a re-write version of this app so it very depends on the community right now.

@ZeroX-DG ZeroX-DG added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Nov 26, 2018
@IssueHuntBot
Copy link

@kazup01 funded this issue with $30. See it on IssueHunt

@IssueHuntBot
Copy link

@kazup01 has cancelled funding for this issue.(Cancelled amount: $30.00) See it on IssueHunt

@IssueHuntBot
Copy link

@issuehuntfest has funded $30.00 to this issue. See it on IssueHunt

@elfman
Copy link
Contributor

elfman commented Dec 26, 2018

I want to work on this issue, what keyboard shortcuts should be customizable? all options in views?

@jvgrootveld
Copy link

jvgrootveld commented Dec 28, 2018

@elfman If you are trying to add more customisable shortcuts, could you check if the shortcut still exist for exiting Editor mode? The wiki - Keyboard Shortcuts describes Ctrl + W as Exit Editor mode but on OSX CMD + W is bound to Exit Window.

@daiyam
Copy link
Contributor

daiyam commented Dec 28, 2018

To be able to customize CodeMirror shortcuts would be great.
But for that many, the keyboard shortcut manager of Visual Studio Code would be a good reference.

@elfman
Copy link
Contributor

elfman commented Dec 29, 2018

@jvgrootveld https://github.com/BoostIO/Boostnote/blob/master/browser/components/MarkdownEditor.js#L17
Editor only listen for ctrl + w, not CMD+W.
But it seems handleKeyDown in MarkdownEditor is not invoked when I press key in the editor. That's strange. I tried on Mac OS

@elfman
Copy link
Contributor

elfman commented Dec 29, 2018

@daiyam customizing shortcuts of editor is a heavy job. There are more than 60 shortcuts in CodeMirror according to its document.
I just want to customize the hotkeys of the menu.

@Flexo013 Flexo013 changed the title Request: Customize All Keyboard Shortcuts Customize All Keyboard Shortcuts Jul 24, 2019
@Flexo013 Flexo013 added funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. and removed 💵 Funded on IssueHunt labels Jul 25, 2019
@Flexo013
Copy link
Contributor

The first priority here should be to make Boostnote's own hotkeys configurable, for example switching to the next and previous note with Ctrl + [ and Ctrl + ].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!
Projects
None yet
Development

No branches or pull requests

8 participants