Skip to content

More hotkeys can be customized in settings page#2751

Closed
elfman wants to merge 1 commit intoBoostIO:masterfrom
elfman:hotkey
Closed

More hotkeys can be customized in settings page#2751
elfman wants to merge 1 commit intoBoostIO:masterfrom
elfman:hotkey

Conversation

@elfman
Copy link
Copy Markdown
Contributor

@elfman elfman commented Dec 26, 2018

for #2645

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 27, 2018
pasteSmartly: OSX ? 'Command + Shift + V' : 'Ctrl + Shift + V'
pasteSmartly: OSX ? 'Command + Shift + V' : 'Ctrl + Shift + V',
reload: OSX ? 'Command + R' : 'Ctrl + R',
devTool: OSX ? 'Command + Alt + I' : 'Control + Shift + I',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow users to customize devTool?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well maybe a user will change it (without knowing what it does) because it conflict with the hotkey that they want and next time they can’t open the dev tool using that hotkey anymore. But I think we can help the user in that case so I guess we can leave it 😄

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think shortcuts only need to be available for frequently used features. Maybe an advanced settings part could be added to optionally set shortcuts to advanced features like the devTool.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking of a scenario where a user wants to use the shortcut that was assigned to devTool so the customizable devTool shortcut in this case is useful

@ZeroX-DG
Copy link
Copy Markdown
Member

ZeroX-DG commented Jun 2, 2020

@elfman sorry for the wait, can you resolve the conflict please?

@ZeroX-DG
Copy link
Copy Markdown
Member

@elfman ping

@ZeroX-DG
Copy link
Copy Markdown
Member

@elfman this is the last ping, I'll take over this if you not interested in it anymore 👍

@ZeroX-DG
Copy link
Copy Markdown
Member

ZeroX-DG commented Jul 3, 2020

Take over here #3601. Thank you for this PR 👍

@ZeroX-DG ZeroX-DG closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants