Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple notes selection #2960

Open
aakbar5 opened this issue Apr 2, 2019 · 14 comments
Open

Multiple notes selection #2960

aakbar5 opened this issue Apr 2, 2019 · 14 comments
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue.

Comments

@aakbar5
Copy link

aakbar5 commented Apr 2, 2019

Issuehunt badges

Current behavior

  • On selecting multiple, app shows the texts of the last selected note.

Expected behavior

Instead of showing texts, it show something following:
Screenshot from 2019-04-02 15-53-18


IssueHunt Summary

Backers (Total: $80.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips

@dredav
Copy link
Contributor

dredav commented Apr 3, 2019

Is this a duplicate of #2935?

@aakbar5
Copy link
Author

aakbar5 commented Apr 5, 2019

Nope, it is different. This feature will allow to execute actions for multiple selected notes at once.

@ZeroX-DG ZeroX-DG added the feature request 🌟 Issue is a new feature request. label Apr 7, 2019
@issuehunt-oss issuehunt-oss bot added the funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. label May 23, 2019
@IssueHuntBot
Copy link

@BoostIO has funded $80.00 to this issue.


@shadabk96
Copy link

I would like to take this up.

@Flexo013
Copy link
Contributor

Flexo013 commented Oct 9, 2019

@shadabk96 Feel free to start! Looking forward to the PR!

@aakbar5
Copy link
Author

aakbar5 commented Jan 16, 2020

@fabiospampinato I couldn't recall where I saw this feature originally but I don't see any reason of not implementing a good feature.

@BoostIO BoostIO deleted a comment from fabiospampinato Jan 19, 2020
@rathod-sahaab
Copy link

So, I have already figured out how to code this. But I need some opinions on specific UX of this feature.

When should the dialog pop up

  1. Immediately i.e. as soon as multiple items are selected
  2. An option should be added to toggle up the dialog

Should we show preview of the files?
Currently, only the preview of most recent selection is shown shown. By preview I mean the file is shown.
Though this works fine with ctrl + click which is used to select one by one but with shift+click multiple notes can be selected at once so preview of most recent note rule doesn't covers that.
Though I believe it's not much of a problem, note titles work fine for me.

What's your view on this @aakbar5

@aakbar5
Copy link
Author

aakbar5 commented Aug 9, 2020

@rathod-sahaab, in my opinion preview should show list or thumbnail of the selected notes instead of any note preview.

@Flexo013
Copy link
Contributor

Flexo013 commented Aug 9, 2020

@rathod-sahaab I would definitely go for option 1. As for previewing the notes, the highlighted titles on the side should be sufficient. For a v1 we could do without the preview, and then add the preview later on.

@rathod-sahaab
Copy link

Thank you @aakbar5 and @Flexo013, I will send the PR soon, currently I am busy with my GSoC projects so will do it on side.

@rathod-sahaab
Copy link

@aakbar5 what are functions of buttons in second row of your mock-up? I can only understand delete

@aakbar5
Copy link
Author

aakbar5 commented Aug 13, 2020

@rathod-sahaab I think icons should be (1) Move to trash (2) Permanently delete (3) Publish (4) Export to pdf or .md files

@rathod-sahaab
Copy link

Instead of a text box where we enter tag name to remove I plan on reusing something like this, where new tag will be added to all, selected and every unique tag from the selection will be shown

tag_add_remove

@rathod-sahaab
Copy link

image
I updated designs a bit for export options shown as different icons, let me know if it's fine, some icons are missing I'll add them soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue.
Projects
None yet
Development

No branches or pull requests

7 participants