Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/display url title #1509

Merged
merged 9 commits into from
Feb 21, 2018
Merged

Conversation

Antogin
Copy link
Contributor

@Antogin Antogin commented Feb 5, 2018

Hi, this is my proposition for request #1482

peek 2018-02-04 17-46

The user can opt out (or should it be a opt in functionality?
peek 2018-02-04 17-51

This is what happens when there is no connection
fail

I use [ ] to tag the url and target it, if there is an invisible character that i can use, it would be cool. I did not find anything usable.
peek 2018-02-04 17-52

@Rokt33r Rokt33r self-requested a review February 5, 2018 21:27
@Rokt33r
Copy link
Member

Rokt33r commented Feb 6, 2018

How about to use <> rather than using invisible character?

<https://github.com> should be rendered as a link like the below.

https://github.com

@Antogin
Copy link
Contributor Author

Antogin commented Feb 6, 2018

Works perfectly! Thanks

@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Feb 7, 2018
@Rokt33r Rokt33r added next release (v0.9.1) and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 21, 2018
@Rokt33r Rokt33r merged commit fea8562 into BoostIO:master Feb 21, 2018
@Antogin Antogin deleted the feat/display-url-title branch March 23, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants