Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1003 Update CodeMirror version #1925

Merged
merged 1 commit into from
May 16, 2018
Merged

Fix #1003 Update CodeMirror version #1925

merged 1 commit into from
May 16, 2018

Conversation

hidaiy
Copy link
Contributor

@hidaiy hidaiy commented May 15, 2018

This is to fix second point of my comment of issue#1003

CodeMirror released new version which fixed this issue.

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 16, 2018
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you exclude package-lock.json? Anyway, thanks for the contributing. 😄

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 16, 2018
to fix issue#1003
@hidaiy
Copy link
Contributor Author

hidaiy commented May 16, 2018

Thank you for your review !
I excluded the package-lock.json.

@Rokt33r Rokt33r added next release (v0.11.5) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels May 16, 2018
@Rokt33r Rokt33r merged commit c9cb31b into BoostIO:master May 16, 2018
@hidaiy hidaiy deleted the develop branch May 23, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants