[Refactor] Use ESLint instead of StandarJS and add settings for TravisCI #231

Merged
merged 13 commits into from Jan 11, 2017

Projects

None yet

2 participants

@sota1235
Member

Update

  • Use ESLint for checking coding style.
  • Add config for using TravisCI.
  • Ignore invalid tests. Fix them after...
@sota1235 sota1235 self-assigned this Jan 11, 2017
@sota1235 sota1235 merged commit f70cf78 into BoostIO:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asmsuechan
Contributor

Hi @sota1235, after this PR was merged, a hot key Toggle Finder(popup) doesn't work properly at least in my environment. Can you check it?

@asmsuechan
Contributor

This commit 5c7804f is doubtful.

@sota1235
Member

Oh, I'm sorry. I'll fix it 🙇

@sota1235
Member

I revert this commit, but I can't fix this bug.
I try to investigate this bug and fix it on next release.

@asmsuechan
Contributor
asmsuechan commented Jan 14, 2017 edited

In my environment, I could fix it by revert the commit. Did you try to restart electron? However the lint fails.

@asmsuechan
Contributor

Oh, I also fail to fix it by revert now 😨

@sota1235 sota1235 removed the Next Release label Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment