Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smart table editor #2312

Merged
merged 4 commits into from
Sep 14, 2018
Merged

add smart table editor #2312

merged 4 commits into from
Sep 14, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Aug 20, 2018

This change allows the use of the smart table editor of @susisu/mte-kernel.
It can be enabled/disabled in the Preferences.

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 22, 2018
@ZeroX-DG
Copy link
Member

Hey @daiyam , thanks for the great feature, but, I notice that the feature will not run if the user don't restart the app, can you fix this?

@daiyam
Copy link
Contributor Author

daiyam commented Aug 25, 2018

@ZeroX-DG I've fixed the issue

@ZeroX-DG
Copy link
Member

LGTM 🎉

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the conflicts?

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed next release (v0.11.10) labels Sep 4, 2018
@daiyam
Copy link
Contributor Author

daiyam commented Sep 4, 2018

@Rokt33r I've fixed the conflicts

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Sep 8, 2018

We should add a blog post on this 😄 too many keyboard shortcut 😄

@ZeroX-DG ZeroX-DG added next release (v0.11.10) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 8, 2018
@Rokt33r Rokt33r merged commit 671dff0 into BoostIO:master Sep 14, 2018
@daiyam daiyam deleted the table-editor branch September 15, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants