Add translation to Portuguese from Portugal #2515
Conversation
ZeroX-DG
added
awaiting review ❇️
|
Hey @FabioRosado , Welcome to Boostnote! Thank you for your contribution, but do you know someone else can review your change? Because I'm not sure if there's anyone here who speaks Portugal |
|
Hello @ZeroX-DG Thank you for the quick reply. I don't know anyone that could review this PR, most people I know only speak English haha |
|
I'm going to merge this in the next week if there is no reviewer! |
locales/pt-PT.json
Outdated
| "FOLDER": "FOLDER", | ||
| "CREATION DATE": "CREATION DATE", | ||
| "NOTE LINK": "NOTE LINK", | ||
| "to create a new note": "para creat uma nova nota", |
locales/pt-PT.json
Outdated
| "STORAGE": "ARMAZENAMENTO", | ||
| "FOLDER": "PASTA", | ||
| "CREATION DATE": "DATA DE CRIAÇÃO", | ||
| "NOTE LINK": "LINK DE NOTA", |
locales/pt-PT.json
Outdated
| "Storage Locations": "Locais de Armazenamento", | ||
| "Add Storage Location": "Adicionar Local de Armazenamento", | ||
| "Add Folder": "Adicionar Pasta", | ||
| "Open Storage folder": "Abrir Local de Armazenamento", | ||
| "Unlink": "Unlink", |
There was a problem hiding this comment.
maybe "Remover a ligação" will fit?
locales/pt-PT.json
Outdated
| "we would like to invest more time and resources in this project.": "gostaríamos de investir mais tempo e recursos neste projeto.", | ||
| "If you use Boostnote and see its potential, help us out by supporting the project on OpenCollective!": "Se gostas deste projeto e vês o seu potencial, podes ajudar-nos através de donativos no OpenCollective!", | ||
| "Thanks,": "Obrigado,", | ||
| "The Boostnote Team": "A Equipa de do Boostnote", |
|
Hello @jangtsekiang thanks for this review, some things I have missed and your suggestions where bang on (I guess living abroad for so long made me unsure in some cases haha) I have decided to opt to use "A Equipa do Boostnote" instead of "de" because it sounded a bit better. Much appreciated for your help @jangtsekiang 😄 👍 |
|
@jangtsekiang Do the changes look fine? |
|
I was thinking about this PR today, do we need to add something to the languages file? Currently there is only one Portuguese which defaults to PT-BR, should this version of Portuguese file be added as a separate language (in some places you can choose PT-BR or PT-PT kind of like the British English and US English)? Or the file will be chosen depending on the system locale? |
|
@FabioRosado I started a PR to your branch. |
add language support for european portuguese
|
@arcturus140 I was going to work on this today after work, thanks a lot for being so quick and add this 😄 👍 I have merged your PR into this branch so now everything should work fine 😄 |
|
Awesome work! @FabioRosado Is it fine to merge now? |
|
@Rokt33r Apologies I should have said yesterday, yeah everything looks good now thank you 😄 👍 |
Rokt33r
added
next release (v0.11.12)
and removed
help wanted 🆘
Hello!
This is my first time contributing to Boosnote, I am not sure if this is the best/right way to contribute with a translation to the project, but I have noticed that Boosnote has a translation for Portuguese from Brazil, since some terms are different in the Portuguese from Portugal I have decided to work on a full translation to it.
I hope this looks good, let me know if I should change something 👍
Thank you for your time