Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2540 #3050

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Fix #2540 #3050

merged 1 commit into from
Jun 3, 2019

Conversation

amedora
Copy link
Contributor

@amedora amedora commented May 31, 2019

Description

This PR disables fuzzy link in markdown.
You should have "http://", "https://" or "ftp://" in URL-ish string to make it link.

Issue fixed

#2540

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible
    link

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 2, 2019
ZeroX-DG
ZeroX-DG approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 2, 2019
@Rokt33r Rokt33r merged commit bc27fd0 into BoostIO:master Jun 3, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jun 3, 2019
@MiloTodt
Copy link
Contributor

MiloTodt commented Jun 3, 2019 •
edited

Will www. work as a link prefix as well?

@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Jun 4, 2019
@amedora amedora deleted the fix-2540 branch June 6, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amedora @MiloTodt @ZeroX-DG @Rokt33r