[Feature] Add support for plantUML mindmap, wbs, gantt #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
requested changes
Sep 18, 2019
browser/lib/markdown.js
Outdated
| @@ -211,6 +211,54 @@ class Markdown { | |||
| } | |||
| }) | |||
|
|
|||
| // Mindmap support | |||
| this.md.use(require('markdown-it-plantuml'), { | |||
There was a problem hiding this comment.
Instead of using require for every type of map, can we just require once and use it here?
const plantuml = require('markdown-it-plantuml');
this.md.use(plantuml, {...})
this.md.use(plantuml, {...})
this.md.use(plantuml, {...})
ZeroX-DG
requested changes
Sep 18, 2019
ZeroX-DG
reviewed
Sep 18, 2019
browser/lib/markdown.js
Outdated
| openMarker: '@startgantt', | ||
| closeMarker: '@endgantt', | ||
| generateSource: function (umlCode) { | ||
| const stripTrailingSlash = (url) => url.endsWith('/') ? url.slice(0, -1) : url |
There was a problem hiding this comment.
Please share this stripTrailingSlash function instead of recreating it every time.
ZeroX-DG
added
awaiting changes 🖊️
ZeroX-DG
added
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of falsely closed pull request #3010
Description
I have added supprt for mindmap, wbs and gantt charts in plantuml. I just copied the part for the part for Ditaa chart and change the @ indicators and switched to svg output.
I havent added any tests, since I am not shure how. Test and lint have same output as current master
Issue fixed
Type of changes
Checklist: