New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing to Github Gist #971

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@phylor

phylor commented Oct 12, 2017

Hi there!

This is a work in progress pull request I'd love to hear your opinion on. It provides sharing to Gist (cf. #455 and #571). You need to create a Github API Token and enter it in preferences (new tab Integrations).

I added a button for markdown notes (top right, next to the info button). It directly shares it to Gist.

screen shot 2017-10-12 at 22 55 16
screen shot 2017-10-12 at 22 55 32

Thoughts I have:

  • I imagine a popup (as when clicking the info button) instead of directly sending it to Gist. This could also host other sharing options (codepen, etc.) and sharing options (e.g. whether the Gist is public or not).
  • Republishing should update the same gist instead of creating a new one
  • It would also be nice to have the HTTPS link to the Gist visible in the share popup
  • Snippets should be shareable as well

What do you think?

I'd love to continue on this if you think it goes in the right direction!

@BoostnoteBot

This comment has been minimized.

Show comment
Hide comment
@BoostnoteBot

BoostnoteBot Oct 12, 2017

Collaborator

Please make sure to be pasted screenshots of all your changes.

Collaborator

BoostnoteBot commented Oct 12, 2017

Please make sure to be pasted screenshots of all your changes.

@BoostnoteBot

This comment has been minimized.

Show comment
Hide comment
@BoostnoteBot

BoostnoteBot Oct 12, 2017

Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

Collaborator

BoostnoteBot commented Oct 12, 2017

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01

This comment has been minimized.

Show comment
Hide comment
@kazup01

kazup01 Nov 7, 2017

Member

Thank you for your suggestion!
We think that this feature should be provided as plugin, not required at default.
There is none plugin feature yet, we will implement it later.

Your suggestion is so great. Thank you again.

Member

kazup01 commented Nov 7, 2017

Thank you for your suggestion!
We think that this feature should be provided as plugin, not required at default.
There is none plugin feature yet, we will implement it later.

Your suggestion is so great. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment