Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add force registration function for personal information #280

Closed
urushibata-k opened this issue Mar 29, 2022 · 4 comments · Fixed by #288
Closed

[FEATURE] Add force registration function for personal information #280

urushibata-k opened this issue Mar 29, 2022 · 4 comments · Fixed by #288
Assignees
Labels
enhancement New feature or request
Projects

Comments

@urushibata-k
Copy link
Collaborator

urushibata-k commented Mar 29, 2022

Is your feature request related to a problem? Please describe.

  • A function is needed to register personal information of the investor originating from issuer.
    e.g) If issuer wants to handle a private placement where the investor key exists in another entity, the issuer needs to perform name registration and transfer operations with issuer authority.

Describe the solution you'd like

  • Either dealing
    • Proposal A: Change the call to function modify in POST: /{bond or share}/tokens/{token_address}/holders/{account_address}/personal_info to function forceRegister.
    • Proposal B: Add new API to call function forceRegister.
    • Proposal C: Add is_force to that API, and switch between function modify or function forceRegister calls.
  • Build the modified PersonalInfo.sol at [FEATURE] Add force registration function to the PersonalInfo contract ibet-SmartContract#370 and replace it with the new JSON file.
@urushibata-k urushibata-k added the enhancement New feature or request label Mar 29, 2022
@urushibata-k
Copy link
Collaborator Author

Assuming personal information registration as preparation before transfer, it is inappropriate for the endpoint to be under /share or /bond(holders).
Adopt Proposal B.

POST: /accounts/{issuer_address}/personal_info

@urushibata-k
Copy link
Collaborator Author

target v22.6.0

@urushibata-k
Copy link
Collaborator Author

urushibata-k commented Mar 31, 2022

Assuming personal information registration as preparation before transfer, it is inappropriate for the endpoint to be under /share or /bond(holders).

PersonalIfno contract's address is set for each token, so it is correct under share or bond.

POST: /{bond or share}/tokens/{token_address}/personal_info

@urushibata-k
Copy link
Collaborator Author

Implemented: branch feature/#280

@urushibata-k urushibata-k self-assigned this Apr 4, 2022
YoshihitoAso added a commit that referenced this issue Apr 4, 2022
feat: personal info force register
@YoshihitoAso YoshihitoAso added this to To do in v22.6.0 via automation Apr 6, 2022
@YoshihitoAso YoshihitoAso moved this from To do to Done in v22.6.0 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v22.6.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants