Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Holders] Get balance list and balance for an account #287

Closed
dhythm opened this issue Mar 31, 2022 · 2 comments · Fixed by #290
Closed

[Holders] Get balance list and balance for an account #287

dhythm opened this issue Mar 31, 2022 · 2 comments · Fixed by #290
Assignees
Labels
enhancement New feature or request
Projects

Comments

@dhythm
Copy link

dhythm commented Mar 31, 2022

Is your feature request related to a problem? Please describe.

Holders api needs token_address at the moment.
So it needs to get all tokens (n) and get all holders (m) (= n * m requests) if we want to get balance for an account.

Describe the solution you'd like

To get balances of holding tokens for an account (an EOA).

Describe alternatives you've considered

To call API with EOA of an account, then return all balances of holding tokens

Additional context

nothing.

@dhythm dhythm added the enhancement New feature or request label Mar 31, 2022
@urushibata-k
Copy link
Collaborator

URL: GET: /position/{account_address}
Header param:

  • issuer-address: optional

Query param:

  • token_type: optional
  • offset: optional
  • limit: optional

URL: GET: /position/{account_address}/{token_address}
Header param:

  • issuer-address: required

@dhythm
Copy link
Author

dhythm commented Apr 1, 2022

I would be awesome if the return value includes token_name, token_address and balance 🙏

@urushibata-k urushibata-k self-assigned this Apr 4, 2022
@YoshihitoAso YoshihitoAso added this to To do in v22.6.0 via automation Apr 6, 2022
@YoshihitoAso YoshihitoAso moved this from To do to In progress in v22.6.0 Apr 6, 2022
v22.6.0 automation moved this from In progress to Done Apr 6, 2022
YoshihitoAso added a commit that referenced this issue Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v22.6.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants