New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reuse contract factory #463

Merged

YoshihitoAso merged 1 commit into dev-23.3 from feature/#379

Jan 13, 2023

Member

purplesmoke05 commented Jan 13, 2023

Close #379

Changes

Modified contract_utils.py so as to reuse web3 contract factory
- factory is generated when we call web3.eth.contract without contract_address arg.
- https://github.com/ethereum/web3.py/blob/v5.31.3/web3/eth.py#L950-L960
- This would slightly reduce memory consumption in indexer batch.


          feat: reuse contract factory

04de7b9

purplesmoke05 requested a review from YoshihitoAso

January 13, 2023 01:10

purplesmoke05 self-assigned this

YoshihitoAso approved these changes

View reviewed changes

YoshihitoAso merged commit 5e6afaa into dev-23.3

YoshihitoAso deleted the feature/#379 branch

January 13, 2023 04:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment