Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing creation of fresh database and linux build error #27

Closed
wants to merge 24 commits into from

Conversation

DuelistRag3
Copy link

Edited Files:

  • 1_auth.sql
  • 2_characters.sql
  • 2022_01_24_world_fix_trainers.sql
  • DBUpdater.h
  • NGrid.h

Created Files

  • 2022_03_22_00_Update_Characters.sql

Also edited:
Master files for hotfix and world database (not included)

Copy link
Author

@DuelistRag3 DuelistRag3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What i did in the base files basically is moving sql querys to fix foreign key errors and removing the database specification at the top (the config file always determines the used database)

For the Linux Build error: not quiet shure if it will cause bugs, but its a hack fix to enable builds on linux

ADD COLUMN `camp_y` int(10) NULL DEFAULT NULL AFTER `camp_x`,
ADD COLUMN `camp_z` int(10) NULL DEFAULT NULL AFTER `camp_y`,
ADD COLUMN `camp_o` int(10) NULL DEFAULT NULL AFTER `camp_z`,
ADD COLUMN `camp_mapid` int(10) NULL DEFAULT NULL AFTER `camp_o`;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that i actually build in a database specification by myself ^^ will fix that later

Copy link
Contributor

@SargeroDeV SargeroDeV Mar 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DuelistRag3 A column of coordinates must always be float, this way it would be fine:
ALTER TABLE characters
ADD COLUMN camp_x float NULL DEFAULT NULL AFTER numRespecs,
ADD COLUMN camp_y float NULL DEFAULT NULL AFTER camp_x,
ADD COLUMN camp_z float NULL DEFAULT NULL AFTER camp_y,
ADD COLUMN camp_o float NULL DEFAULT NULL AFTER camp_z,
ADD COLUMN camp_mapid smallint(5) NULL DEFAULT NULL AFTER camp_o;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes totaly sence yes

Copy link
Contributor

@SargeroDeV SargeroDeV Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But mapid is not a float but an int so it is declared as smallint
ADD COLUMN camp_mapid smallint(5) NULL DEFAULT NULL AFTER camp_o;

@Nexon99
Copy link
Contributor

Nexon99 commented Apr 7, 2022

Tested and working ? Win + Linux ?

@Nexon99
Copy link
Contributor

Nexon99 commented Jul 17, 2022

@DuelistRag3 up

@Thordekk
Copy link
Collaborator

Any news on that pr or is abandoned?

@Nexon99 Nexon99 closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants