-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing creation of fresh database and linux build error #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What i did in the base files basically is moving sql querys to fix foreign key errors and removing the database specification at the top (the config file always determines the used database)
For the Linux Build error: not quiet shure if it will cause bugs, but its a hack fix to enable builds on linux
ADD COLUMN `camp_y` int(10) NULL DEFAULT NULL AFTER `camp_x`, | ||
ADD COLUMN `camp_z` int(10) NULL DEFAULT NULL AFTER `camp_y`, | ||
ADD COLUMN `camp_o` int(10) NULL DEFAULT NULL AFTER `camp_z`, | ||
ADD COLUMN `camp_mapid` int(10) NULL DEFAULT NULL AFTER `camp_o`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw that i actually build in a database specification by myself ^^ will fix that later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DuelistRag3 A column of coordinates must always be float, this way it would be fine:
ALTER TABLE characters
ADD COLUMN camp_x
float NULL DEFAULT NULL AFTER numRespecs
,
ADD COLUMN camp_y
float NULL DEFAULT NULL AFTER camp_x
,
ADD COLUMN camp_z
float NULL DEFAULT NULL AFTER camp_y
,
ADD COLUMN camp_o
float NULL DEFAULT NULL AFTER camp_z
,
ADD COLUMN camp_mapid
smallint(5) NULL DEFAULT NULL AFTER camp_o
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes totaly sence yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But mapid is not a float but an int so it is declared as smallint
ADD COLUMN camp_mapid
smallint(5) NULL DEFAULT NULL AFTER camp_o
;
Tested and working ? Win + Linux ? |
@DuelistRag3 up |
Any news on that pr or is abandoned? |
Edited Files:
Created Files
Also edited:
Master files for hotfix and world database (not included)