Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve drag-and-drop playlist implementation #136

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Mar 6, 2023

Improved drag-and-drop behavior:

  • Allows to drag playlists on playlist-editor, when no playlists are opened yet
  • Allows to drag playlist into another playlists, or if opened as a new playlist
  • Allows to to drag a playlist as a new tab

image

Debt:

  • Remove redundant code

Technical debt remaining:

  • Dragging a playlist is now converted as M3U with corresponding MIME-type, instead of proprietary string. Yet needs much refinement. Dragging entries from one playlist to another will not work correctly.

Depends on io.github:borewit:lizzy:1.2.0

@Borewit Borewit self-assigned this Mar 6, 2023
@Borewit
Copy link
Owner Author

Borewit commented Mar 6, 2023

Build: listFix_2.6.0-PR136-29.exe

If you have time to review @touwys, it's all yours

@touwys
Copy link

touwys commented Mar 7, 2023

Build: listFix_2.6.0-PR136-29.exe

If you have time to review @touwys, it's all yours

Thanks, I am onto it.

@touwys
Copy link

touwys commented Mar 7, 2023

Did you read my comment about the Themes, here? #106 (comment)

@touwys
Copy link

touwys commented Mar 7, 2023

Testing: listFix_2.6.0-PR136-29.exe

Improved drag-and-drop behavior:

* Allows to drag playlists on playlist-editor, when no playlists are opened yet ✔️ 

* Allows to drag playlist into another playlists, or if opened as a new playlist ✔️

* Allows to to drag a playlist as a new tab ❓ 

Not sure what you mean by this?


ℹ️ What is missing, is support for dragging playlists from folders in the PLD, to dropping it into the PLE.

@Borewit
Copy link
Owner Author

Borewit commented Mar 7, 2023

Allows to to drag a playlist as a new tab

Be able to drag in a playlist like this, (the visualization may deviate)

image

Did you read my comment about the Themes, here? #106 (comment)

Yes I did, I agree with that. Better one solid theme, than 5 which are so so. There are still so many area's this application could improve. Sometimes I don't know where to start. I want to give JavaFx a try to see if that is doable and maybe a better investment for the future. But also also would like to utilize Lizzy better, to concentrate all the playlist functionality in there. Currently it is only used for iTunes playlists. And to distribute ListFix an AppImage.

@touwys
Copy link

touwys commented Mar 7, 2023

Be able to drag in a playlist like this, (the visualization may deviate)

I cannot test this just now, to figure it out. Probably, tomorrow. How does it differ from the first item on your list: "Allows to drag playlists on playlist-editor,..."?


About the Themes: We agree then. However, on having second thoughts, it might be worthwhile to consider retaining just one dark theme along with light default. Should I go ahead and post the proposed theme modification as an issue/improvement?


There are still so many area's this application could improve. Sometimes I don't know where to start.

You have made extremely good progress, and we already have a functional app, where a short time ago we had no such thing Therefore, don't worry too much, and do not try to do too many things at a time. Stick to ticking off the "boxes" like you're doing now, and just keep your focus, and the pace, steady.

Although I do not know the first thing about programming/coding, I really want to assist you, by helping you to determine some of the listFix() priorities from a user point of view. For instance, I think the next in line for your attention should be saving the current layout (or session) upon closing the app, because it's such a drag on the user having to start over before commencing to edit again, a previously abandoned, incomplete session.

@Borewit Borewit force-pushed the improve-playlist-drag-and-drop branch from 64b5f79 to cd0cc6b Compare March 7, 2023 17:50
@Borewit
Copy link
Owner Author

Borewit commented Mar 7, 2023

I cannot test this just now, to figure it out. Probably, tomorrow. How does it differ from the first item on your list: "Allows to drag playlists on playlist-editor,..."?

Dragging the playlist to this location will assume the playlists should be opened, as it is not dragged into another playlist

About the Themes: We agree then. However, on having second thoughts, it might be worthwhile to consider retaining just one dark theme along with light default. Should I go ahead and post the proposed theme modification as an issue/improvement?

Let's postpone the detailed visual improvements, I started playing with JavaFX, I may redo the entire GUI. Will take a bit of time, it's like 4000 km journey by foot.

I think the next in line for your attention should be saving the current layout (or session) upon closing the app, because it's such a drag on the user having to start over before commencing to edit again, a previously abandoned, incomplete session.

I can make some progress in that area.

@touwys
Copy link

touwys commented Mar 8, 2023

Dragging the playlist to this location will assume the playlists should be opened, as it is not dragged into another playlist

OK, then I have tested this too, already, and found it is working perfectly well just like the other two drag and drop operations. A full score!


Let's postpone the detailed visual improvements, I started playing with JavaFX, I may redo the entire GUI. Will take a bit of time, it's like 4000 km journey by foot.

Yes, from a practicality point of view, the GUI is not so important at all, unless it interferes with operations.


Let me know if there perhaps is something specific you want me to look out for in this test build?

BTW, is it purely coincidental, or have you done some work to improve the PLAY-button display: Select Best Mach / Preview / PLAY upon changes to the font style & size? Though anomalies are still visible when applying larger text, there appears to be a discernible improvement around the more commonly used font sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants