Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 9 Platform Module System (JPMS) #164

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Support Java 9 Platform Module System (JPMS) #164

merged 1 commit into from
Apr 22, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Apr 21, 2023

Changes:

  1. Support Java 9 Platform Module System (JPMS)
  2. Use jlink to build application.
  3. Uploads Windows runtime image as an artifact

Use jlink to build application
@Borewit Borewit added the debt Technical debt label Apr 21, 2023
@Borewit Borewit self-assigned this Apr 21, 2023
@Borewit
Copy link
Owner Author

Borewit commented Apr 21, 2023

Can you try to run the Windows build @touwys?

Are you able to locate this build by yourself? See #160 for guidance.

@touwys
Copy link

touwys commented Apr 22, 2023 via email

@Borewit
Copy link
Owner Author

Borewit commented Apr 22, 2023

I tried to download the build, via the link, with another account.
I got the 404 error (not found) initially as well. It required you to be signed into GitHub. After I signed in, it worked.

This how to access the Windows build artifacts:

screen-capture.webm

@Borewit
Copy link
Owner Author

Borewit commented Apr 22, 2023

The behavior of the console is configurable:

noConsole = false

Do I capture that initial error? Good question. In a way no. If the application cannot be started it's on the OS the handle with that error. Unless the launching mechanism takes care of way of capturing that..

When building background applications, services, we indeed capture this kind of output, by redirecting the console output to a file.

Next is to turn wrap this "runtime image" into an installer which hopefully better integrates it with Windows, or Linux.

@touwys
Copy link

touwys commented Apr 22, 2023

It required you to be signed into GitHub. After I signed in, it worked.

Yes, thanks for the reminder.


This how to access the Windows build artifacts:

No video found


The behavior of the console is configurable:
178 noConsole = false

I suppose you are going to keep the default set as "false", for the time being?

Incidentally, I did notice that the app settings were retained from the previous installation — even though I have "cleanly" removed the installation before installing this distribution. This can only mean that the app is not self-contained — yet? Where does it store the settings info?

Here is the DOS-log is you still need it for any reason:


listFix_win — DOS_console_log.txt


@Borewit
Copy link
Owner Author

Borewit commented Apr 22, 2023

Application settings are always stored in %USERPROFILE%\.listFix(), close to the log files, in the parent folder.

  1. .listFix()\history.json
  2. .listFix()\mediaLibrary.json
  3. .listFix()\options.json

You can open those files with a text editor.

So these are the traces left behind by listFix() independent of the distribution.
I think that is perfectly acceptable. Very few application leave so little behind.

@touwys
Copy link

touwys commented Apr 22, 2023 via email

@Borewit Borewit merged commit 441fa4e into main Apr 22, 2023
@Borewit Borewit deleted the jlink branch April 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants