Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cancellation behavior in fix playlist dialogs #199

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Sep 17, 2023

Prevent repair job from keep running when user cancels at the repair stage.

@Borewit Borewit self-assigned this Sep 17, 2023
@Borewit Borewit force-pushed the improve-cancellation-behaviour branch from 7a4a4ff to 0408bd3 Compare September 17, 2023 11:24
@Borewit Borewit force-pushed the improve-cancellation-behaviour branch from 0408bd3 to 5457ceb Compare September 17, 2023 11:29
@github-actions
Copy link

@Borewit
Copy link
Owner Author

Borewit commented Sep 17, 2023

Are you able to review this PR @touwys?

Corresponding Windows build.

@Borewit Borewit force-pushed the improve-cancellation-behaviour branch from 6cc0bee to 3ac7249 Compare September 17, 2023 14:02
@github-actions
Copy link

@github-actions
Copy link

@touwys
Copy link

touwys commented Sep 17, 2023

listFix 2.8.0_7 — Ref Issue #194 — Review

The issue persists. After having saved, the first round of (exact) repairs, and going to track number 1 which still needs to be matched:

  1. Select track 1.
  2. Right-click for its context menu to open.
  3. Select "Repair playlist"
  4. Select the match, and click OK to return to the list still open in the editor. (Note: In this particular instance, only one match was found).
  5. Track number 1 is correctly replaced with the match found.
  6. Repeat Steps 1-4 above, for the next track in line to find a match for. (Let's say this track is number 7)
  7. Track 1 is now discarded, and gets replaced with track 7.
  8. This issue repeats whenever steps 1-4 above are repeated with other tracks, which require matches: Each time, Track 1 will get replaced with the newer match.

Note: This issue could probably be related to issue #196

@Borewit
Copy link
Owner Author

Borewit commented Sep 17, 2023

listFix 2.8.0_7 — Ref Issue #194 — Review

The issue persists. After having saved, the first round of (exact) repairs, and going to track number 1 which still needs to be matched:

  1. Select track 1.
  2. Right-click for its context menu to open.
  3. Select "Repair playlist"
  4. Select the match, and click OK to return to the list still open in the editor. (Note: In this particular instance, only one match was found).
  5. Track number 1 is correctly replaced with the match found.
  6. Repeat Steps 1-4 above, for the next track in line to find a match for. (Let's say this track is number 7)
  7. Track 1 is now discarded, and gets replaced with track 7.
  8. This issue repeats whenever steps 1-4 above are repeated with other tracks, which require matches: Each time, Track 1 will get replaced with the newer match.

Note: This issue could probably be related to issue #196

This PR only address step 2 of issue #194, to actually cancel the job. It indeed does not resolve other behavior described in #194.

@touwys
Copy link

touwys commented Sep 18, 2023

listFix 2.8.0_7 — Ref Issue #194 — Review Revised

Resolves behavior described in issue #194, step 2:

Immediately, after having it detect all the exact matches, cancel the "Select Closest Matches" dialogue still in progress. Accordingly, it should not proceed with next trying to detect the closest matches.

Can confirm that the above issue has been taken care of with this release.

Thank you.

@Borewit Borewit merged commit 395652e into main Sep 18, 2023
4 checks passed
@Borewit Borewit deleted the improve-cancellation-behaviour branch September 18, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants