Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename repair playlist entries in context menu #206

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Rename repair playlist entries in context menu #206

merged 1 commit into from
Sep 27, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Sep 24, 2023 •
edited
Loading

  • Rename context menu entries:
    • "Repair Playlist" to "Repair selected entry" / "Repair selected entries"
    • "Edit Filenames" to "Edit track filename" / "Edit track filenames"
    • "Replace Selected Entry" to "Replace selected entry" / "Replace selected entries"
    • "Copy Selected Items To..." to "Copy selected tracks to..." / "Copy selected tracks to..."
    • "Open File Location" to "Open track location" / "Open track locations"

Applied terminology:

  • A playlist entry, or "entry" is a reference to a track
  • Track is the actual file a playlist entry refers to

Resolves #179

@Borewit Borewit self-assigned this Sep 24, 2023
@Borewit Borewit marked this pull request as draft September 24, 2023 08:26
@Borewit Borewit force-pushed the rename-repair-playlist-entries branch from 1a788d9 to dca388c Compare September 24, 2023 08:54
Repository owner deleted a comment from github-actions bot Sep 24, 2023
@Borewit Borewit force-pushed the rename-repair-playlist-entries branch from dca388c to c5f1cef Compare September 24, 2023 08:57
@Borewit Borewit marked this pull request as ready for review September 24, 2023 08:57
@touwys
Copy link

touwys commented Sep 24, 2023

@Borewit

Moving along rapidly...

@Borewit Borewit force-pushed the rename-repair-playlist-entries branch from c5f1cef to 10b932c Compare September 25, 2023 18:22
Repository owner deleted a comment from github-actions bot Sep 25, 2023
@Borewit Borewit force-pushed the rename-repair-playlist-entries branch from 10b932c to 64f0eba Compare September 26, 2023 17:24
Repository owner deleted a comment from github-actions bot Sep 26, 2023
@Borewit
Copy link
Owner Author

Borewit commented Sep 26, 2023

Shall we just merge this one @touwys, are do you want to check it first?

@github-actions
Copy link

Build run (#6316210834, attempt #1) artifacts

@touwys
Copy link

touwys commented Sep 26, 2023

Shall we just merge this one @touwys, are do you want to check it first?

Since it's a non-operational component, I think it's safe to merge without having to check it first.

@Borewit Borewit merged commit e5c1201 into main Sep 27, 2023
4 checks passed
@Borewit Borewit deleted the rename-repair-playlist-entries branch October 23, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardisation of Context Menu Terminology
2 participants
@Borewit @touwys