Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Lizzy to 3.0.1, change M3U text encoding to ISO-8859-1 #224

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Oct 22, 2023

⚠️ Warning: may have issues reading M3U generated with previous versions as the encoding changed from UTF-8 to ISO-8859-1.

Resolves #223

Playlist previously saved as .m3u maybe causing character encoding issues. Best to rename those to .m3u8 and load with liftFix() and save as .m3u if required.

@Borewit Borewit added the dependencies Pull requests which update a dependency file label Oct 22, 2023
@Borewit Borewit self-assigned this Oct 22, 2023
@Borewit
Copy link
Owner Author

Borewit commented Oct 22, 2023

@touwys, can you review this PR?

@Borewit Borewit added the bug Something isn't working label Oct 22, 2023
@Borewit
Copy link
Owner Author

Borewit commented Oct 22, 2023

Saving a playlist m3u8 is broken, it saves as m3u.

When saving as `.m3u8`, use UTF-8 encoding
@Borewit Borewit force-pushed the update-dependency-lizzy-3.0.1 branch from 18af0c1 to b6b3e3d Compare October 22, 2023 17:15
@github-actions
Copy link

Repository owner deleted a comment from github-actions bot Oct 22, 2023
@touwys
Copy link

touwys commented Oct 23, 2023

Best to rename those to .m3u8 and load with liftFix() and save as .m3u if required.

Is it imperative to rename the *.m3u playlist file extensions to the *.m3u8 file extension outside listFix() before they get added to the Playlist Directories (PD) pane? Because, the file extension can also be changed to *.m3u8 while the *,m3u files are already present in the PD. If the file extension gets renamed from *.m3u to *.m3u8 inside the listFix() PD, instead of renaming it with an external app, does it make any difference, or pose a potential risk?

@touwys
Copy link

touwys commented Oct 23, 2023

Review: listFix() 3.0.1-2_4cb01be

Steps:

  1. Two sets of playlist files were tested. Each set consisted of two playlist files — one with the *.m3u file extension, and one with the *.m3u8 file extension. The two files in each set were mirrors of each other.
  2. One set was renamed with an external app, and one set was renamed while present inside the listFix() Playlist Directories pane.
  3. These 4 files were opened in the Editor simultaneously.
  4. All 4 files were fully repaired in one operation.
  5. The playlist repairs concluded successfully, and the results were consequently saved.
  6. No further testing was done.

Annotated Screenshots:

image


image

@Borewit
Copy link
Owner Author

Borewit commented Oct 23, 2023

The safest option is to rename playlists outside listFix(). You might as well simply repair broken playlists. If the playlist turns green there is no issue. The only difference is how special characters are encoded.

@touwys
Copy link

touwys commented Oct 23, 2023

You might as well simply repair broken playlists.

Yes, that's exactly how it's usually done. Rarely, if ever, find it necessary for another approach. Other user perspectives may differ though, and it's fitting to have that support in listFix() on standby.

@Borewit Borewit merged commit 82db28c into main Oct 23, 2023
4 checks passed
@Borewit Borewit deleted the update-dependency-lizzy-3.0.1 branch October 23, 2023 18:30
@Borewit Borewit changed the title Update dependency Lizzy to io.github.borewit:lizzy:3.0.1 Update dependency Lizzy to 3.0.1, change M3U text encoding to ISO-8859-1 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests which update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem playing back M3U files in foobar2000 and Windows Media Player
2 participants