Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-module inclusion for better browser compatibility #147

Closed
Borewit opened this issue Sep 19, 2018 · 1 comment
Closed

Sub-module inclusion for better browser compatibility #147

Borewit opened this issue Sep 19, 2018 · 1 comment
Assignees
@Borewit
Labels
enhancement

Comments

@Borewit
Copy link
Owner

Borewit commented Sep 19, 2018 •
edited

In addition to include the full module, allow only 'core' functionality using sub-module inclusion, e.,g:

import * as mm from 'music-metadata/lib/core';
function music-metadata music-metadata/lib/core
parseBuffer ✓ ✓
parseStream * ✓ ✓
parseFromTokenizer ✓ ✓
parseFile ✓

Related to:

  1. Depend on music-metadata music-metadata-browser#5
  2. Restructure to centralize types and… strtok3#17
  3. Be able to run music-metadata in the browser #107
@Borewit Borewit self-assigned this Sep 19, 2018
Borewit added a commit that referenced this issue Sep 19, 2018
@Borewit
#147: Sub-module inclusion for better browser compatibility
3905d1f
This was referenced Sep 19, 2018
Merged
Merged
Borewit added a commit that referenced this issue Sep 19, 2018
@Borewit
#147: Update README
37b743e
@Borewit
Copy link
Owner Author

Borewit commented Sep 19, 2018

Implemented in v3.1.0.

@Borewit Borewit closed this as completed Sep 19, 2018
@Borewit Borewit mentioned this issue Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borewit Borewit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Borewit