Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DSF (DSD Stream File) format #195

Closed
volumio opened this issue Apr 5, 2019 · 6 comments
Closed

Add support for DSF (DSD Stream File) format #195

volumio opened this issue Apr 5, 2019 · 6 comments
Assignees
@Borewit
Labels
enhancement

Comments

@volumio
Copy link

volumio commented Apr 5, 2019 •
edited by Borewit

Feature Request

The library does not support the quite popular DSD format (dff and dsf).
See here for specifications:
https://dsd-guide.com/sites/default/files/white-papers/DSFFileFormatSpec_E.pdf

I am willing to offer support to make it happen

PR: #197
@Borewit
Copy link
Owner

Borewit commented Apr 6, 2019

Definitely something music-metadata should support.
Sounds like a plan, let's do it @volumio.

@Borewit Borewit self-assigned this Apr 6, 2019
@volumio
Copy link
Author

volumio commented Apr 6, 2019

@Borewit Great.

Tell me how can I support and I'll do it. If you want we can communicate directly via mail at info at volumio dot org

@Borewit
Copy link
Owner

Borewit commented Apr 6, 2019

I'll have a chat channel using Discord: https://discord.gg/KyBr6sb

If the implementation is doable, I assume you can test it.
I will assess to understand what else needs to be done.
Sample data for unit test is strongly desired, I'll like to keep the audio samples as small as possible.

@volumio volumio changed the title Add support for DSD format Add support for DSF format Apr 6, 2019
Borewit added a commit that referenced this issue Apr 6, 2019
@Borewit
#195 Add DSF audio format parser
f4c92de
@Borewit Borewit mentioned this issue Apr 6, 2019
Merged
6 tasks
Borewit added a commit that referenced this issue Apr 6, 2019
@Borewit
#195 Add DSF to README
2feb815
Borewit added a commit that referenced this issue Apr 6, 2019
@Borewit
#195 Add keywords 'dsd' & 'dsf' to NPM
0014186
@Borewit Borewit mentioned this issue Apr 6, 2019
Closed
@Borewit Borewit changed the title Add support for DSF format Add support for DSF (DSD Stream File) format Apr 7, 2019
@Borewit
Copy link
Owner

Borewit commented Apr 7, 2019 •
edited

Beta version released with DSF parser: 3.6.0-beta.0

@Borewit Borewit mentioned this issue Apr 9, 2019
Merged
7 tasks
Borewit added a commit that referenced this issue Apr 9, 2019
@Borewit
#195 Implement format.bitrate & format.lossless
20ec202
Borewit added a commit that referenced this issue Apr 9, 2019
@Borewit
#195 Fix minor errors in DSF chunk parsing
4263624
@Borewit
Copy link
Owner

Borewit commented Apr 9, 2019

Fixed bitrate for DSF format in: 3.6.0-beta.1

@Borewit Borewit mentioned this issue Apr 22, 2019
Merged
3 tasks
@Borewit
Copy link
Owner

Borewit commented Apr 22, 2019

Implemented in v3.6.0

@Borewit Borewit closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borewit Borewit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@volumio @Borewit