Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/async updates #126

Merged
merged 29 commits into from
Aug 16, 2018
Merged

Feature/async updates #126

merged 29 commits into from
Aug 16, 2018

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Aug 2, 2018 •
edited
Loading

Implentation of #125 / webtorrent/webtorrent-desktop#1340

Async updates of metadata found in an audio stream.

  • Implement a central component triggered (using a function) with tag updates from each parser.
  • Update common metadata at the fly.
  • Extend the API with async updates.

@Borewit Borewit self-assigned this Aug 2, 2018
@Borewit Borewit mentioned this pull request Aug 2, 2018
Closed
1 task
@coveralls
Copy link

coveralls commented Aug 2, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 93.311% when pulling 474114e on feature/async-updates into 9436f16 on master.

@Borewit Borewit mentioned this pull request Aug 13, 2018
Merged
4 tasks
Borewit and others added 15 commits August 13, 2018 12:20
@Borewit
#125 Send async observer event after a format property has changed.
c110c24
@Borewit
#125 Adjust unit test to include format updates.
a92c8cf
@Borewit
#127 Fix parsing ©gen with type well-known-type set to 18.
513aab6
@Borewit
Minor: export abstract class
4e230cd
@Borewit
©gen should be decoded as text
78704e3
@Borewit
Restructure MP4-Parser. Free the 'Atom' class, to use that name for b…
6e637c8 
…ean class holding the bean.
@Borewit
Merge branch 'master' into fix/issue-127
b999391
@Borewit
Merge branch 'master' into feature/async-updates
455ddbb 
# Conflicts:
#	src/mp4/MP4Parser.ts
@Borewit
Use IgnoreType token for ignored data.
3587154
@Borewit
Merge branch 'fix/issue-127' into feature/async-updates
d05b6b4 
# Conflicts:
#	src/mp4/MP4Parser.ts
@Borewit
Merge branch 'feature/async-updates' of https://github.com/Borewit/mu…
7829183 
…sic-metadata into feature/async-updates
@Borewit
Refactor MP4 parser: MP4 atom structure reader
daee9f9
@Borewit
Merge pull request #130 from Borewit/refactor/mp4-atom-reader
655c3a7 
Refactor MP4 parser: MP4 atom structure reader
@Borewit
Remove unused code
84905bb
@Borewit
Rename listener to dataHandler
83947df
@Borewit Borewit merged commit a2829ba into master Aug 16, 2018
@Borewit Borewit deleted the feature/async-updates branch August 16, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @coveralls