Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oh My Posh install script #2346

Closed
3 tasks done
libewa opened this issue Jun 1, 2023 · 7 comments · Fixed by #2376
Closed
3 tasks done

Oh My Posh install script #2346

libewa opened this issue Jun 1, 2023 · 7 comments · Fixed by #2376

Comments

@libewa
Copy link
Contributor

libewa commented Jun 1, 2023

What is the name of the app?

Oh My Posh

(Optional) Where is the app hosted?

https://github.com/jandedobbeleer/oh-my-posh
I download the official install script, which detects the architecture, from https://ohmyposh.dev.

About the app

Oh My Posh adds customizable prompts to many shells, including bash, zsh, pwsh and fish.
Prompts are configured via json files and activated by adding a command to ~/.bashrc

Upload file or Add PR Link

Oh My Posh.zip
PR #2376

Confirmations

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

@theofficialgman
Copy link
Collaborator

multiple issues with your install and uninstall scripts

I suggest you take a look at what the https://ohmyposh.dev/install.sh script actually does and integrate this into the install script in pi-apps itself. there is no reason to run their wrapper script which has no error checking. all it does is download the latest release binary and themes from the github releases and add them to the proper installation directory.

you should not leave orphaned files on the users install or execute extraneous commands either (eg: don't run purge_packages if you never ran install_packages)

also, please post a response with a picture of what your terminal looks like before and after installing this. I am having trouble understanding what it is for, what it does, and why you want it from the description and the website.

@libewa
Copy link
Contributor Author

libewa commented Jun 2, 2023

i also went on the omp discord for instructions on how to uninstall, and jan said to not use the install script on linux, but to use go install

@libewa

This comment was marked as outdated.

@theofficialgman
Copy link
Collaborator

theofficialgman commented Jun 2, 2023

please refer to #2346 (comment)
I do not want go install. pi-apps should manage the version of "oh my posh" by installing from github releases just like the https://ohmyposh.dev/install.sh does. refer to the tldr script as an example of downloading the release from github and moving to the correct folder integrated in pi-apps https://github.com/Botspot/pi-apps/blob/master/apps/tldr/install-32

also I still need the the last request there answered.

@libewa
Copy link
Contributor Author

libewa commented Jun 2, 2023

ah yeah

@libewa
Copy link
Contributor Author

libewa commented Jun 3, 2023

Screenshot:
image
new zip:
Oh My Posh.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants