-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Chromium: install Raspberry Pi Foundation chromium on rpi Ubuntu #2529
Conversation
8810432
to
11346b7
Compare
|
73018d1
to
92a7aad
Compare
Also I am fairly sure that for widevine to show up at all on ubuntu, this logic needs to be changed to display the widevine option for the #detect if Widevine is enabled
if [ -d /opt/WidevineCdm ];then
widevine=TRUE
else
widevine=FALSE
fi
#detect if Widevine can be enabled
if package_available libwidevinecdm0 && package_installed chromium-browser;then
widevine_possible=TRUE
widevine_message=(--field="Enable Widevine DRM (for Netflix, Spotify)":CHK "$widevine")
else
widevine_possible=FALSE
widevine_message=()
fi |
Nope. The logic is good and working since the piOS There is no such |
It appeared to me that the # Ubuntu must be 22.10+ (GLIBC 2.36+) to be compatible with widevine
if printf '%s\n' "22.10" "$__os_release" | sort -CV; then
echo 'Package: chromium*
Pin: release o=Pi-Apps-Coders chromium-debs
Pin-Priority: 1000
Package: libwidevinecdm0
Pin: release o=Pi-Apps-Coders chromium-debs
Pin-Priority: 500
Package: chromium*
Pin: release o=Ubuntu*
Pin-Priority: -1' | sudo tee /etc/apt/preferences.d/chromium >/dev/null But now I see your wildcard character |
Yes. There are other packages that need to be included. Refer to the apt repo https://github.com/Pi-Apps-Coders/chromium-debs/releases/tag/apt-release |
|
Also, surely you have ruled out the option for directly using the https://archive.raspberrypi.com/debian/ repo on ubuntu but restricting it to only offer the chromium packages, right? |
@Botspot yes, that was previously done, see 92a7aad . I ruled it too dangerous if the user happened to remove the pin they could end up with a broken system. It also triggers the frankendebian check so that is another problem with using it. |
yeah that is fine as well. The pi-apps-coders chromium-debs apt repos contents are fixed so the exact pin format does not really matter. |
9ae33de
to
fc08215
Compare
safer than adding the entire archive.raspberrypi.com repo. If the user removed the pin priority they could break their system. only show libwidevinecdm0 on 22.10+ suggestion from #2528 closes #2528 use force removal of pi-apps-coders-chromium repo since Better Chromium requires that chromium be installed before running, chromium will never get purged as part of purge_packages since it must have either been marked manually installed or automatically installed by another package
fc08215
to
a62e441
Compare
I have tested every iteration of this. I think it is all working as intended and suggested here #2528 (comment) |
@Botspot is anything else needed here? |
Looks good. Merge at will. |
61b0d97
to
fe42388
Compare
fe42388
to
d4f7d22
Compare
suggestion from #2528
closes #2528
see https://github.com/Pi-Apps-Coders/chromium-debs for the repo that re-hosts the rpi debs