Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add mac os example #152

Merged
merged 15 commits into from Feb 3, 2022
Merged

Feature/add mac os example #152

merged 15 commits into from Feb 3, 2022

Conversation

andrew-winn-br
Copy link
Contributor

Had to add Catalyst support because a Catalyst app uses the iOS/Catalyst version of a framework, not the macOS version.
This should complete #6
Screen Shot 2022-02-03 at 11 54 36 AM
Screen Shot 2022-02-03 at 11 54 17 AM

@andrew-winn-br andrew-winn-br requested a review from a team as a code owner February 3, 2022 19:31
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@andrew-winn-br
Copy link
Contributor Author

Linter error is:

PackageDescription.SupportedPlatform:5:24: note: 'macCatalyst' was introduced in PackageDescription 5.5
PackageDescription.SupportedPlatform:33:27: note: 'v13' was introduced in PackageDescription 5.5

and the current package description for Hyperspace is 5.1. I think I can just remove the .macCatalyst(.v13) line from Package.Swift and it should still be fine. .macCatalyst was added as a specific platform for SPM in Xcode 13, but Catalyst was supported before that.

@wmcginty
Copy link
Contributor

wmcginty commented Feb 3, 2022

@andrew-winn-br I think we go ahead and upgrade the minimum tools version to 5.5, especially as this isn't going straight into a release we don't have to immediately worry about compatibility issues.

wmcginty
wmcginty requested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@wmcginty wmcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me, but can you also add a CHANGELOG.md entry?

Example/Sources/macOS/ViewController.swift Outdated Show resolved Hide resolved
@andrew-winn-br
Upgrade to tools version 5.5
ebe59e4
@andrew-winn-br
Incorporate PR feedback:
ca90a4a 
Update change log
Remove "created by" line
Add macOS deployment target.
wmcginty
wmcginty previously approved these changes Feb 3, 2022
View reviewed changes
@andrew-winn-br
Incorporate PR feedback:
53009a5 
Add debugPrint statements for deleting user posts.
@wmcginty wmcginty merged commit 2d58125 into BottleRocketStudios:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmcginty wmcginty wmcginty approved these changes

@br-earl-gaspard br-earl-gaspard br-earl-gaspard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrew-winn-br @CLAassistant @wmcginty @br-earl-gaspard