Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly encode ampersand in forms #155

Merged
merged 2 commits into from Apr 19, 2022
Merged

Properly encode ampersand in forms #155

merged 2 commits into from Apr 19, 2022

Conversation

andrew-winn-br
Copy link
Contributor

No description provided.

@andrew-winn-br andrew-winn-br requested a review from a team as a code owner April 19, 2022 14:33
wmcginty
wmcginty reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@wmcginty wmcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak to the definition of the character set, otherwise this looks good!

Sources/Core/Request/FormURLEncoder.swift Outdated Show resolved Hide resolved
@wmcginty wmcginty requested a review from a team April 19, 2022 14:51
@wmcginty wmcginty merged commit f1e814c into BottleRocketStudios:main Apr 19, 2022
@andrew-winn-br andrew-winn-br deleted the bugfix/Ampersand_Form_Encoding branch April 19, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmcginty wmcginty wmcginty approved these changes

@br-earl-gaspard br-earl-gaspard br-earl-gaspard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-winn-br @wmcginty @br-earl-gaspard