Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Carthage Support #25

Merged
merged 9 commits into from Aug 1, 2019
Merged

Added Carthage Support #25

merged 9 commits into from Aug 1, 2019

Conversation

ganttastic
Copy link
Contributor

Removed CocoaPods in favor of carthage for local dependency management. Added documentation.

tylermilner
tylermilner previously approved these changes Jul 30, 2019
README.md Show resolved Hide resolved
wmcginty
wmcginty previously approved these changes Jul 30, 2019
Copy link
Contributor

@wmcginty wmcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ganttastic - looks like Travis is looking for and missing a Podfile though.

@ganttastic ganttastic dismissed stale reviews from wmcginty and tylermilner via 3c3ff6b July 31, 2019 14:29
@ganttastic
Copy link
Contributor Author

@wmcginty Whoops! Forgot about swapping travis.

@ganttastic
Copy link
Contributor Author

@wmcginty / @tylermilner FINALLY got the build to pass. The keychain is a pain... good for review.

@ganttastic ganttastic merged commit c54fa61 into master Aug 1, 2019
@ganttastic ganttastic deleted the feature/carthage branch August 1, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants