-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child views not being configured #80
Comments
Hey @brayden4012 thanks for the report - I think this should be fixed by #79 . Do you think you could run the sample project against the |
Worked like a charm on my test project! However I'm not seeing the same
results in the project I'm currently working on. The only difference
between the two is that I'm initializing 3 pods from UtiliKit in my current
project. In the podfile, I call all 3 of those pods from the same branch in
the github repo. Any thoughts?
…On Fri, Sep 13, 2019, 11:12 AM Will McGinty ***@***.***> wrote:
Hey @brayden4012 <https://github.com/brayden4012> thanks for the report -
I think this should be fixed by #79
<#79> . Do you
think you could run the sample project against the transitionIssue_iOS13
to see if that fixes it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#80?email_source=notifications&email_token=AKJPSJHGWF75NNBIHBJHG33QJPCZFA5CNFSM4IWSF7G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6VUPXQ#issuecomment-531318750>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKJPSJFZ7DX6CFLSKKCEPJ3QJPCZFANCNFSM4IWSF7GQ>
.
|
Are you seeing any warnings in the console like |
I havent seen any errors
…On Fri, Sep 13, 2019, 1:10 PM Will McGinty ***@***.***> wrote:
Are you seeing any warnings in the console like unbalanced calls to
begin/end appearance transition for view controller ? That's usually
indicative of something going wrong in the container's transition animator.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#80?email_source=notifications&email_token=AKJPSJBWMUCD5WNX5X5FVMLQJPQTLA5CNFSM4IWSF7G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6V54BI#issuecomment-531357189>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKJPSJAO3MJPIIDLCAYG3K3QJPQTLANCNFSM4IWSF7GQ>
.
|
*warnings
…On Fri, Sep 13, 2019, 1:39 PM Brayden Harris ***@***.***> wrote:
I havent seen any errors
On Fri, Sep 13, 2019, 1:10 PM Will McGinty ***@***.***>
wrote:
> Are you seeing any warnings in the console like unbalanced calls to
> begin/end appearance transition for view controller ? That's usually
> indicative of something going wrong in the container's transition animator.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#80?email_source=notifications&email_token=AKJPSJBWMUCD5WNX5X5FVMLQJPQTLA5CNFSM4IWSF7G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6V54BI#issuecomment-531357189>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AKJPSJAO3MJPIIDLCAYG3K3QJPQTLANCNFSM4IWSF7GQ>
> .
>
|
This looks to have been resolved. Closing. |
Whenever I called the
transitionToController(for child:completion:)
method, only my first view controller is constrained within the container view controller. All subsequent calls to the method does not configure the other view controllers to fit inside the container view.UtiliKitContainerViewBug.zip
The text was updated successfully, but these errors were encountered: