Extend CLLocationCoordinate2D with isValid computed property
#102
Conversation
Extend CLLocationCoordinate2D with `isValid` computed property
Sources/UtiliKit/General/CLLocationCoordinate2D+Extensions.swift
Outdated
Show resolved
Hide resolved
Sources/UtiliKit/General/CLLocationCoordinate2D+Extensions.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Earl Gaspard <83370606+br-earl-gaspard@users.noreply.github.com>
Incorporate PR feedback Change import
|
It would be great to get some unit tests added for this. |
Should it be a new version number? |
|
@andrew-winn-br just an entry under the "Enhancements" section. We'll create a version number entry when we do the next release of Utilikit. See this change on a previous PR for an example. |
Add tests Update Change log
Tests/UtiliKitTests.swift
Outdated
| longitude: CLLocationDegrees(-180)) | ||
| ] | ||
|
|
||
| XCTAssertNil(coordinates.first { !$0.isValid }) |
There was a problem hiding this comment.
This may just be personal preference, but to me this would be more clear as XCTAssertTrue(coordinates.allSatisfy { $0.isValid })
There was a problem hiding this comment.
Agreed. I can change it and the invalid coordinates test.
Clarify tests.
br-tyler-milner
dismissed stale reviews from br-earl-gaspard, wmcginty, and themself
via
6176de8
|
@rmirabelli looks like this just needs your thumbs up for us to go ahead and merge. |
|
@andrew-winn-br I think in addition to Russell's re-approval we'll want to merge in the changes from main to get the updated CI running over the PR. |
|
You know what, looking at it - it's a small enough change that I'll just deal with any weirdness on the release branch :). Merging. |
Attempting to use an invalid coordinate will crash the app. This provides a convenient computed property to check if a CLLocationCoordinate2D is valid or not.