Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Carthage Support #68

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Added Carthage Support #68

merged 3 commits into from
Jul 30, 2019

Conversation

ganttastic
Copy link
Contributor

UtiliKit built with Carthage out of the box. I only had to change the current Cartfile to a private one so it wouldn't be pulled for the end project using it. More about that here.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@wmcginty wmcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I don't suppose you are planning on using Hyperspace/Scotty/SessionTools/KeyboardSupport as well? 😄

@ganttastic
Copy link
Contributor Author

@wmcginty Yep! I'm going to go down the list and add as many as I can. Hyperspace is next.

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         433    433           
=====================================
  Hits          433    433

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b90bad...24d04f8. Read the comment docs.

@ganttastic ganttastic merged commit 32e4ec8 into master Jul 30, 2019
@ganttastic ganttastic deleted the feature/carthage branch July 30, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants