Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure completion handler is called #76

Merged
merged 2 commits into from Sep 1, 2019
Merged

Ensure completion handler is called #76

merged 2 commits into from Sep 1, 2019

Conversation

wmcginty
Copy link
Contributor

No description provided.

@wmcginty wmcginty mentioned this pull request Aug 30, 2019
Closed
tylermilner
tylermilner previously approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@tylermilner tylermilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suppose there's any way to easily make a unit test for this? 😁

@wmcginty
Copy link
Contributor Author

There's probably quite a bit of testing that can be done, but I figured I'd get the bug fix in quickly, then test later.

@tylermilner
Copy link
Contributor

Ah, the classic "fix now, test later" excuse. 😜

@codecov-io
Copy link

codecov-io commented Aug 30, 2019 •
edited

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #76   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         433    433           
=====================================
  Hits          433    433

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff09f2...71f6072. Read the comment docs.

@wmcginty
Copy link
Contributor Author

wmcginty commented Aug 30, 2019 •
edited

Exactly 😄 . I did however add a changelog entry @tylermilner

@tylermilner tylermilner merged commit 10aa862 into master Sep 1, 2019
@tylermilner tylermilner deleted the completionFix branch September 1, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylermilner tylermilner tylermilner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wmcginty @tylermilner @codecov-io