Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include non-selected components in BOM #65

Closed
t123yh opened this issue Oct 29, 2021 · 2 comments · Fixed by #69
Closed

Add option to include non-selected components in BOM #65

t123yh opened this issue Oct 29, 2021 · 2 comments · Fixed by #69

Comments

@t123yh
Copy link

t123yh commented Oct 29, 2021

Currently, all components have to be selected in order to be included in BOM. However, most resistors and capacitors can be automatically matched in JLC, making it unnecessary (and painful) to select them manually. (The slow, laggy UI adds extra pain in the ass if there are 30's individual values of resistors: every select makes the UI freeze for 3 seconds)

@Bouni
Copy link
Owner

Bouni commented Oct 30, 2021

I think instead of managing a list of non-lcsc parts we should use the include in BOM function here and include all parts that are not marked as exclude from BOM and ignore their lcsc property!?

@t123yh
Copy link
Author

t123yh commented Oct 30, 2021

I think instead of managing a list of non-lcsc parts we should use the include in BOM function here and include all parts that are not marked as exclude from BOM and ignore their lcsc property!?

Yes, I think you are right.

@Bouni Bouni mentioned this issue Oct 30, 2021
Bouni added a commit that referenced this issue Nov 2, 2021
@Bouni Bouni linked a pull request Nov 2, 2021 that will close this issue
@Bouni Bouni closed this as completed in #69 Nov 2, 2021
Bouni added a commit that referenced this issue Nov 2, 2021
Allow missing LCSC property in BOM/CPL, fix for #65
Bouni added a commit that referenced this issue Nov 29, 2022
Allow missing LCSC property in BOM/CPL, fix for #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants