Possible fix for Plugin Crash

[Bouni]

It was pointed out by a KiCAD developer that the self.app = wx.App() might be the problem. See issue 15520 for details.
Removing it solved the issue for me but most likely will bring back #291

So I looked at KiBuzzards source an shamelessly stole two lines from there 😅

[Bouni]

@hansfbaier would you mind testing this against your Ubuntu 22.04 installation? I think you were the only one that had problems (at least the only one reporting it in #291)

@badrbouslikhin @octave @shuki25 can one of you confirm that this doesn't break the plugin for MacOS?
(you reported back in #295)

[Bouni]

@HaiJin-Yun can you test this PR as well an see if it fixes your problem?

[hansfbaier]

@hansfbaier would you mind testing this against your Ubuntu 22.04 installation? I think you were the only one that had problems (at least the only one reporting it in #291)

@badrbouslikhin @octave @shuki25 can one of you confirm that this doesn't break the plugin for MacOS? (you reported back in #295)

Hello, I can confirm that working. Thanks!

[HaiJin-Yun]

Ubuntu 22.04 Where can I download it?
Do you mean the April 2022 version?
In this version, the database is not down and parts search is not activated.
The service seems to have stopped.
That's why I got the latest version.

[Bouni]

@HaiJin-Yun Ubuntu 22.04 is the operating system, not the plugin.
You cannot download the main branch zip and install it via KiCAD PCM, that doesn't work!

As I'm also on Windows and for me the issue seems fixed I'll just wait for one of the OSX users to report back and merge the fix.

[badrbouslikhin]

@Bouni I can confirm this branch seems to work on macOS. Haven't done much besides opening the plugin and moving between Settings and main window.
I got a few errors on the logs, but they seem unrelated to this commit.

❯ ./pcbnew
Starting plugin CircularZone
Starting plugin ViaStitching
2023.09.01 10:04:46 - DEBUG - download -  Parts db is split into 3 parts. Proceeding to download...
2023.09.01 10:04:46 - DEBUG - download -  Removing any spurios old zip part files...
2023.09.01 10:04:46 - DEBUG - download -  Removing /Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/jlcpcb/parts.db.zip.001.
2023.09.01 10:04:46 - DEBUG - download -  Download parts db chunk 1 with a size of 76.29MB
2023.09.01 10:04:52 - DEBUG - download -  Download parts db chunk 2 with a size of 76.29MB
2023.09.01 10:05:05 - DEBUG - download -  Download parts db chunk 3 with a size of 27.74MB
2023.09.01 10:05:07 - DEBUG - download -  Combining and extracting zip part files...
Traceback (most recent call last):
  File "/Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/mainwindow.py", line 556, in populate_footprint_list
    if not self.store:
AttributeError: 'JLCPCBTools' object has no attribute 'store'
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Top layer
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Silk top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Mask top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Paste top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Bottom layer
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Silk top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Mask bottom
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Paste bottom
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Edges
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted V score cut
2023.09.01 10:05:28 - INFO - generate_excellon -  Finished generating Excellon files
2023.09.01 10:05:28 - INFO - zip_gerber_excellon -  Finished generating ZIP file
Traceback (most recent call last):
  File "/Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/mainwindow.py", line 915, in generate_fabrication_data
    self.fabrication.generate_cpl()
  File "/Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/fabrication.py", line 271, in generate_cpl
    for part in self.parent.store.read_pos_parts():
AttributeError: 'JLCPCBTools' object has no attribute 'store'

[HaiJin-Yun]

Bouni

Bouni You made my work very convenient.
thank you
I hope it gets resolved well.