rotations.py - Cleanup BoxSizer flags #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents inside of vertical BoxSizers
The flag produces an assertion error as only horizontal alignment is possible inside of vertical sizers.
Assertion output:
Traceback (most recent call last):
File "/Users/cmorgan/Documents/KiCad/8.0/scripting/plugins/kicad-jlcpcb-tools/mainwindow.py", line 883, in manage_rotations
RotationManagerDialog(self, "").ShowModal()
File "/Users/cmorgan/Documents/KiCad/8.0/scripting/plugins/kicad-jlcpcb-tools/rotations.py", line 89, in __init__
sizer_right.Add(correction_label, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, 5)
wx._core.wxAssertionError: C++ assertion "CheckSizerFlags(!((flags) & (wxALIGN_CENTRE_VERTICAL)))" failed at ./src/common/sizer.cpp(2273) in DoInsert(): wxALIGN_CENTRE_VERTICAL will be ignored in this sizer: only horizontal alignment flags can be used in vertical sizers
Bouni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inactive wx.ALIGN_CENTER_VERTICAL flags on elem…ents inside of vertical BoxSizers
The flag produces an assertion error as only horizontal alignment is possible inside of vertical sizers.
Assertion output:
Traceback (most recent call last):
File "/Users/cmorgan/Documents/KiCad/8.0/scripting/plugins/kicad-jlcpcb-tools/mainwindow.py", line 883, in manage_rotations
RotationManagerDialog(self, "").ShowModal()
File "/Users/cmorgan/Documents/KiCad/8.0/scripting/plugins/kicad-jlcpcb-tools/rotations.py", line 89, in init
sizer_right.Add(correction_label, 0, wx.ALL | wx.ALIGN_CENTER_VERTICAL, 5)
wx._core.wxAssertionError: C++ assertion "CheckSizerFlags(!((flags) & (wxALIGN_CENTRE_VERTICAL)))" failed at ./src/common/sizer.cpp(2273) in DoInsert(): wxALIGN_CENTRE_VERTICAL will be ignored in this sizer: only horizontal alignment flags can be used in vertical sizers