Panel support

[Bouni]

This should fix #440

[chmorgan]

Only comment I'd make is that the commit subject and body for the first commit doesn't help with understanding the change. For kit kit are there multiple parts with the same refdes? In the fixed case clearly it's iterating over all footprints via self.board.Footprints() vs. what might not be all footprints(?) using read_pos_parts()?

[Bouni]

For kit kit are there multiple parts with the same refdes?

Exactly, KiKit takes a board an multiplies it so that it can be manufactured as a panel.
That means on a 2x2 panel we have 4x C1 for example.

The problem is the line after the read_pos_parts:

https://github.com/Bouni/kicad-jlcpcb-tools/blob/main/fabrication.py#L262

board.FindFootprintByReference gives a random position for a given ref, that way we end up with jus one part in the POS / BOM file.

Here you can see the problem very good: #440 (comment)

I did it the other way, iterating over all parts I get from the board and look that up in the store.

I hope that makes sense 😅

[chmorgan]

If you could put that info into the commit message imo that would help the next person follow the change. This is what I had suspected the change was. That we were iterating over all parts, grouping and matching by refdes for the component info.

…

On Mon, Jun 10, 2024 at 2:55 AM bouni ***@***.***> wrote: For kit kit are there multiple parts with the same refdes? Exactly, KiKit takes a board an multiplies it so that it can be manufactured as a panel. That means on a 2x2 panel we have 4x C1 for example. The problem is the line after the read_pos_parts: https://github.com/Bouni/kicad-jlcpcb-tools/blob/main/fabrication.py#L262 board.FindFootprintByReference gives a random position for a given ref, that way we end up with jus one part in the POS / BOM file. I did it the other way, iterating over all parts I get from the board and look that up in the store. I hope that makes sense 😅 — Reply to this email directly, view it on GitHub <#480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJH4AEUAX7567YDLELMDMDZGVEVNAVCNFSM6AAAAABI6VTKWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJXGQ3TAOJSGA> . You are receiving this because your review was requested.Message ID: ***@***.***>