Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong update dialog #38

Open
mgian opened this issue Oct 14, 2020 · 2 comments
Open

Wrong update dialog #38

mgian opened this issue Oct 14, 2020 · 2 comments

Comments

@mgian
Copy link
Contributor

mgian commented Oct 14, 2020

Got an wrong update dialog, version compiled 0.8.0, got a dialog for update that point to the 0.7.0

What I've done:

  1. new pc (never used GPXLab on) with Window 10
  2. cloned repository (updated to upstream/master)
  3. compiled (64 bit if that matter)
  4. run (from QtCreator) and got the dialog that a new update is available. But the dialog point to the 0.7.0 release, while I am running the 0.8.0 from git.

Any subsequent run does not show the dialog (even if it should check for them)

Not sure is really a problem BTW.
Will try to reproduce as soon as I will change (again :-( ) the PC

@BourgeoisLab
Copy link
Owner

The proposed update version is based on the official release.
https://github.com/BourgeoisLab/GPXLab/releases/latest

This is currently v0.7. V0.8 is not officially released yet.

@mgian
Copy link
Contributor Author

mgian commented Oct 15, 2020

I think I nailed it.
On the first run (when there is nothing saved in the preferences) the value of mDateSince is invalid since it cannot be read from the settings.

Then the check

if (dtPublished > mDateSince)

in the method

bool Dialog_CheckUpdate::parseReplyGithub(const QByteArray& str)

always return True, so the dialog is showed, even if probably is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants