Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow : notation for path #34

Merged
merged 2 commits into from
Jul 12, 2014
Merged

allow : notation for path #34

merged 2 commits into from
Jul 12, 2014

Conversation

thebyrd
Copy link
Member

@thebyrd thebyrd commented Jul 11, 2014

Hello @larzconwell,

Please review the following commits I made in branch 'thebyrd-special-sync-path'.

a05828f (2014-07-11 18:34:36 -0400)
allow : notation for path

R=@larzconwell

@larzconwell
Copy link
Member

We should consider instead using a root option in bowery.json and when adding set default to /application, also changing up delancey.Upload to use service.Root.

If we're going with the : route we should add content to the add commands wizard messaging for max clarity.

@thebyrd
Copy link
Member Author

thebyrd commented Jul 12, 2014

@larzconwell I agree. I've added Remote Path to bowery add. We should talk more about it on Monday's beef meeting. I think we need to make the bowery.json a little easier to understand or at least document it better with more complex examples.

thebyrd pushed a commit that referenced this pull request Jul 12, 2014
@thebyrd thebyrd merged commit 74a607c into master Jul 12, 2014
@thebyrd thebyrd deleted the thebyrd-special-sync-path branch July 12, 2014 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants